Skip to content

Conversation

@souvikghosh04
Copy link
Contributor

Why make this change?

  • Reference associated issue using # syntax. e.g. Closes #XX
    • Include summary (1-2 sentences) of linked issue to avoid redirecting reviewers to different pages.
    • Include links to any additional discussion threads related to this change.

What is this change?

  • Summary of how your changes work to give reviewers context of your intent.
    • Links to relevant documentation / StackOverflow, if applicable.

How was this tested?

  • Integration Tests
  • Unit Tests

Sample Request(s)

  • Example REST and/or GraphQL request to demonstrate modifications
  • Example of CLI usage to demonstrate modifications

@souvikghosh04
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 6 pipeline(s).

@souvikghosh04
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 6 pipeline(s).

@souvikghosh04
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 6 pipeline(s).

- Added IgnoreMember for RuntimeOptions.Mcp in ModuleInitializer
- Regenerated all 4 ConfigurationTests verified snapshots without Mcp section
- All ConfigurationTests now pass locally (4/4)
- Mcp configuration properly excluded from snapshot testing
…mparison issues

- Removed the 'mcp' section from dab-config.MsSql.json test configuration file
- This prevents the Mcp configuration from being deserialized and appearing in test snapshots
- The IgnoreMember setting in ModuleInitializer.cs was not fully preventing Mcp property serialization
- Removing Mcp from source config file ensures clean snapshot comparisons
- All 4 ConfigurationTests (MsSql, MySql, PostgreSql, Cosmos) now passing (0 failed, 4 passed)

Resolves MS SQL pipeline test failure in TestReadingRuntimeConfigForMsSql where:
- UserProvidedAllTools was showing as 'true' in received vs 'false' in verified
- Stored procedure GraphQL Operation was showing as 'Mutation' vs expected 'Query'
@souvikghosh04
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 6 pipeline(s).

…ization

- Reordered Entity.cs properties from (GraphQL, Rest, Mcp, Permissions) to (Rest, GraphQL, Mcp, Permissions)
- Updated constructor parameters to match property order
- Fixed test files using old constructor parameter order
- Accepted snapshots with corrected property ordering

This ensures System.Text.Json serialization produces consistent output, preventing
snapshot test failures in pipelines where deserialization-reserialize cycles would
produce different property ordering.
@souvikghosh04
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 6 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants